Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !13829

Always use preserveComment: 'some'

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/BBosman/preserve into master Jun 15, 2014
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: BBosman

While creating the bootstrap.js file during grunt dist a header gets added to that file.

When we then create the bootstrap.min.js file from it, we don't specify a preserveComments setting in the uglify:bootstrap task so the default will be to strip that banner out, but because we specify an explicit banner setting it gets added right back in.

Therefore we could change the banner setting to a preserveComments: 'some' setting, without changing the output.

But this would result in all uglify tasks having a preserveComments: 'some' setting, so we could hoist that setting up to be a global uglify setting.

This PR makes those changes.

The generated .min.js files are identical.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/BBosman/preserve