Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !14354

Button: Fix `checked` prop on button's input not always applied correctly

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/hnrch02/fix-buttons-checked-prop into master Aug 08, 2014
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: hnrch02

Fixes #14137 (closed)

This fixes it properly rather than just reverting 4b40ee69.

Example: http://jsbin.com/kudav/1

BTW, the key to reproducing the problem mentioned in #14137 (closed) is to search for the point in the button where the cursor is in its default state and by that hovering over the invisible checkbox. Said checkbox can also be clicked and that's what is primarily causing these problems. This was introduced by #12794.

/cc @cvrebert @fat @Kolyunya @pixelchutes

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/hnrch02/fix-buttons-checked-prop