Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !14410

Refactoring grid implementation.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/seven-phases-max/refactoring-grid-framework into master Aug 17, 2014
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 4

Created by: seven-phases-max

This is a "preview" PR for discussion and feedback. Since there're several possible methods each with its own pros and cons I had to write a small (pseudo)-blog-post about this. Please read.


(Updated) This PR implements Method #1. The generated CSS should be equal to what it is now, except 5 added dummy classes (.col-any-any, .col-xs-any, .col-sm-any, .col-md-any, .col-lg-any) plus the generated grid classes are (intentionally) reordered. (Note also that all mixins are rewritten and reordered so the diff view does not make any sense).


A few questions. I'm not sure if "coding guidelines" questions (specifically "What Less features may we use?") are appropriate here but since this directly affects the code in the PR I guess I'll ask. In particular:

  • Pattern Matching. I can see that when guards are always used even where the "Pattern-Matching" would result in more clean and less verbose code: is there any special reason behind this?
  • Temporary variables. I also was not able to find (though I could just miss) even a single temporary variable (specifically a temporary variable inside a mixin) in the sources: is there any special reason for this?

Thanks.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/seven-phases-max/refactoring-grid-framework