Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !14870

Modify navbar-toggle to scale better

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/redbmk/master into master Oct 24, 2014
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: redbmk

The navbar-toggle button had a hard-coded size, making it difficult to adjust the size of the navbar. I used some variables to reverse-engineer the current defaults that also look decent with different navbar sizes. I tested by adjusting @navbar-height to 30px and @grid-gutter-width to 18px (same proportions as the default 50/30). It doesn't rely directly on @grid-gutter-width, so changing navbar-padding-horizontal directly should work as well (and look better if the goal is to make the navbar larger).

The bars on the button also didn't respect preferences for border radius.

I compiled the code using grunt to get a new css mapping, but the css compiles down to the same results as before for bootstrap.css and bootstrap.min.css.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/redbmk/master