Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !15140

Fix regression: make media-body consume full available width

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/shesek/patch-1 into master Nov 15, 2014
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: shesek

The addition of #14801 made media-body not consume the full available width, due to the use of display: table-cell. This is problematic when the media body has visible borders or elements floated to its right (see example - v3.2.0 vs v3.3.1).

This PR fixes this by applying width: 100% to media-body and display: table to the main media element, as was done in the flag object article referenced from the original feature request issue, #14799 (closed).


My 2c: I don't think that applying table displays to all media elements is a good idea. Using table/table-cell makes elements behave quite differently and may cause things to break in odd ways.

While my suggested change might fix this issue, I'm not sure that it doesn't cause others. I would much rater have vertical alignment and table display as an opt-it, either by specifying an additional class on the media element ("media-valign"?) or by making it a completely different component ("flag"?), rather than changing the behavior of an existing component and possibly breaking existing code.

If you prefer, I can send a pull request that does that instead.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/shesek/patch-1