Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !15353

Modal window, scrollbar shift regression

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/thcipriani/regression/modal-body-shift into master Dec 12, 2014
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 7

Created by: thcipriani

Current getbootstrap.com:

Modal shift in IE11

This was a problem that was originally solved by 09072442

A regression was caused by the removal of the line:

if (document.body.clientWidth >= window.innerWidth) return 0;

from the measureScrollbar function in commit da74fba4

This seems like a mistake. Further, checking if document.body.scrollHeight > document.documentElement.clientHeight (the current scrollbar detection solution) is insufficient to check for the presence of scrollbars on IE10/IE11. IE10/IE11 don't have a scrollbar width since the scrollbar is hidden a majority of the time because of the CSS @-ms-viewport { width: device-width; }

I believe the situation is similar for Chrome on OSX, but I haven't tested that.

Either way, the solution in this commit shouldn't interfere with the goals of da74fba4 as far as I can tell AND fixes an important regression.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/thcipriani/regression/modal-body-shift