Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !15648

Improve image layout in the carousel example.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/Nikita240/master into master Jan 23, 2015
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 2

Created by: Nikita240

The way the featurette images positioned themselves when the display was below the md threshold was very ugly.

Before After
Original layout Modified layout

Not only does it look better, it also does a much better job of showcasing bootstrap functionality. The new layout is a good example of the usefulness of push/pull. It also serves to educate people about .center-block, because it is instinctual for people to try to center images with text-align, but in this case that would not work since .img-responsive changes the display type on the the img to block (which the website has no mention of btw). See this guy (I made the same mistake): https://github.com/twbs/bootstrap/issues/14596.

I used this template in my project, and it took me a good while to figure out how to fix these two problems.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Nikita240/master