Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !15694

Fix issue where affixed element has incorrect positioning

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/Xegyn/affix-fix-for-sticky-footer-layout into master Jan 29, 2015
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: Xegyn

when used with a sticky footer layout.

Fixes issue that was introduced in Bootstrap 3.3.0 (reference: https://github.com/twbs/bootstrap/issues/15032), introduced by this commit: https://github.com/twbs/bootstrap/commit/724c4f526cd56a28bb305fe6f1f31f3091bf2cd6

The scrollable height used to be the document, which would be correct in the case of using a sticky footer layout where body is set to 100%, which is essentially the viewport height.

The commit that changed it to body height broke this, but fixed a bug where the document height was smaller than the body height.

This fix takes the max of the document height and body height, which should allow the affixed element to have the correct position in either case.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Xegyn/affix-fix-for-sticky-footer-layout