Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !15877

Wrap breadcrumbs with <nav>

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/kkirsche/patch-2 into master Feb 23, 2015
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: kkirsche

This pull request wraps the breadcrumb component in a <nav> element per recommendations from:

  • http://stackoverflow.com/questions/25326699/proper-aria-handling-of-breadcrumb-navigation
  • http://www.uvd.co.uk/blog/accessible-breadcrumbs-using-aria/
  • https://gist.github.com/jonathantneal/4037764

And it adds the role="breadcrumbs" as shown in the W3C list found here: http://www.w3.org/TR/2007/WD-aria-role-20070601/#breadcrumbs

EDIT: Apparently HTML Lint doesn't support the role=breadcrumbs so that is removed. Following up with grunt-html at jzaefferer/grunt-html#41

EDIT 2: role=breadcrumbs was removed from the spec

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/kkirsche/patch-2