Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !16142

Compare tooltip right offset to viewport right offset (and not width)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/Intrepidd/patch-1 into master Mar 24, 2015
  • Overview 0
  • Commits 4
  • Pipelines 0
  • Changes 2

Created by: Intrepidd

Hi !

There seems to be a bug on viewport bound check.

Instead of checking that the right offset of the tooltip is not bigger than the right offset of the viewport, you check it's not bigger to the viewport size. This causes wrong offsets being applied in some conditions.

I'm willing to add a unit test if you acknowledge this issue but this will be complicated as qunit tests run in a div with a negative positionning, that will prevent the bug from happening.

Thanks

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Intrepidd/patch-1