Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !16345

Combined Media Queries

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/gotbahn/combine-media-queries into master Apr 23, 2015
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 16

Created by: gotbahn

Bootstrap uses a lot of repeated media queries, this is proposal to combine them.

I found in issue tracker quite similar, approved pull request "Media query mixins" #13014. But it only changes hardcoded media queries to mixins (in my opinion not in better way to write code inside) and what is more important not combining media queries in output CSS.

So inside proposal changed all media queries to media mixins declarations, that called in media-queries.less file collector.

Media mixins naming composed of parts from media queries: @media screen and (min-width: @screen-sm-min) {...} -> .media-screen-min-sm() {...}

Benefits:

  • combined media queries;
  • reduced little bit size of bootstrap.css from 3kb, bootstrap.min.css from 2.5kb
  • mechanism to scale media queries for LESS Bootstrap users without adding post processors

Concerns:

  • non standard way of use mixins possible only in LESS
  • CSS way to write media queries, media mixins should always wrap content
  • I founded that bootstrap not supported LESS extends, so didn't find way better than add .navbar-form to .form-inline. Of course form.less should not know anything about navbar.less.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/gotbahn/combine-media-queries