Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !17047

Fixed couple of formatting errors in modal.md (v4)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/petetnt/petetnt-v4-dev-patch-1 into v4-dev 9 years ago
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: petetnt

One extra </p> was out of place, plus couple of issues with `'s which caused some odd formatting.

Compare
  • v4-dev (base)

and
  • latest version
    66a9ed27
    1 commit, 2 years ago

1 file
+ 3
- 3

    Preferences

    File browser
    Compare changes
docs/components/modal.md
+ 3
- 3
  • View file @ 66a9ed27

  • Edit in single-file editor

  • Open in Web IDE


@@ -39,7 +39,7 @@ There are some caveats regarding using modals on mobile devices. [See our browse
### Static example
A rendered modal with header, body, and set of actions in the footer.</p>
A rendered modal with header, body, and set of actions in the footer.
<div class="bd-example bd-example-modal">
<div class="modal">
@@ -172,7 +172,7 @@ Toggle a modal via JavaScript by clicking the button below. It will slide down a
{% callout warning %}
#### Make modals accessible
Be sure to add `role="dialog"` and `aria-labelledby="..."``, referencing the modal title, to `.modal`, and `role="document"` to the `.modal-dialog` itself.
Be sure to add `role="dialog"` and `aria-labelledby="..."`, referencing the modal title, to `.modal`, and `role="document"` to the `.modal-dialog` itself.
Additionally, you may give a description of your modal dialog with `aria-describedby` on `.modal`.
{% endcallout %}
@@ -264,7 +264,7 @@ For modals that simply appear rather than fade in to view, remove the `.fade` cl
## Using the grid system
To take advantage of the Bootstrap grid system within a modal, just nest `.container-fluid within the `.modal-body` and then use the normal grid system classes within this container.
To take advantage of the Bootstrap grid system within a modal, just nest `.container-fluid` within the `.modal-body` and then use the normal grid system classes within this container.
{% example html %}
<div id="gridSystemModal" class="modal fade" tabindex="-1" role="dialog" aria-labelledby="gridModalLabel" aria-hidden="true">
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
3
CI skip-changelog v5
3
CI skip-changelog v5
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference: twbs/bootstrap!37751
Source branch: github/fork/petetnt/petetnt-v4-dev-patch-1

Menu

Explore Projects Groups Snippets