Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !17094

Use Tether's addTargetClasses option instead of manually removing classnames

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/lincolndbryant/v4-dev into v4-dev Aug 20, 2015
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 7

Created by: lincolndbryant

As of Tether 0.7.1 (May 2015) - we introduced addTargetClasses, which prevents adding any classnames to the target el when false. I confirmed this with the visual tests, but can add a unit test if helpful.

I found the issue referenced in the comment and will resolve, sorry that got lost.

Thanks so much for incorporating Tether!

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/lincolndbryant/v4-dev