Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !17241

v4: Change the default value of $font-size-sm to .875rem

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/tagliala/font-size-sm-fix into v4-dev Aug 23, 2015
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: tagliala

Hi,

I was taking a look at the new typography and I found that the only non-round value was the one generated from $font-size-sm.

$font-size-root:             16px !default;

$font-size-base:             1rem !default;    // 16px
$font-size-lg:               1.25rem !default; // 20px
$font-size-sm:               .85rem !default;  // 13.6px <--
$font-size-xs:               .75rem !default;  // 12px

$font-size-h1:               2.5rem !default;  // 40px
$font-size-h2:               2rem !default;    // 32px
$font-size-h3:               1.75rem !default; // 28px
$font-size-h4:               1.5rem !default;  // 24px
$font-size-h5:               1.25rem !default; // 20px
$font-size-h6:               1rem !default;    // 16px

$display1-size:               3.5rem !default; // 56px
$display2-size:               4.5rem !default; // 72px
$display3-size:               5.5rem !default; // 88px
$display4-size:               6rem !default;   // 96px

This PR changes the default value of $font-size-sm from .85rem to .875rem, which gives us a round 14px font size.

Sorry if the 13.6px value was intended

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/tagliala/font-size-sm-fix