Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !17402

Accept elements as the tooltip / popover content

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge pr-14552-v4 into v4-dev Aug 31, 2015
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 6

Created by: glebm

When a DOM node is passed to an HTML tooltip, the node is only moved if it is not already in the tooltip. If a DOM node is passed to a plain text tooltip, its text is copied via jQuery .text().

Replaces .detach() with .empty(), as .detach() is almost never useful but instead leaks memory. The difference between empty and detach is that the latter keeps all the attached jQuery events/data. However, since we do not return the previous children, the user would have to keep these themselves, thus they can detach() if necessary.

This is a port of https://github.com/twbs/bootstrap/pull/14552 to v4.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: pr-14552-v4