Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !17403

Change grid and container sizes from em/rem to px

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge use-px-for-window-sizes into v4-dev Aug 31, 2015
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 4

Created by: glebm

Changes grid and container sizes to px, as the viewport pixel size does not depend on the font size.

The actual em values were inconsistent with the docs, while the docs were not the same as the comments:

  • sm breakpoint was 34em (544px) not 480px.
  • lg container max-width was 60rem (960px), less gutter than md. Changed to 940px, same as Bootstrap 3.
  • xl container max-width was 72.25rem which is 1140px not 1156px. Changed to 1140px matching the comment but not the docs.

Addresses #17070 (closed) and #17388.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: use-px-for-window-sizes