Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !17468

Restrict collapse effect to within Modal if applicable

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/FirstVertex/patch-2 into master Sep 03, 2015
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: FirstVertex

Our app is a CMS where you hover over a section to edit it. The edit occurs in a Modal. Html is copied verbatim from the source (on the page) to a ContentEditable area (on the modal). We are stuck having 2 elements on the page with the same ID, because of this. We noticed that if we have a Collapsible area, it doesn't work in the modal, since Bootstrap was just using the data-target as a straight selector (within the whole document scope).

I believe it is unlikely and ill-advised, for someone to want an element within a Modal, to trigger a collapsible that is not within that Modal. Therefore I feel like this is a safe and harmless modification that helps with the condition I mentioned.

In my local copy of Bootstrap I've made the above modification, which works great for us. I submit it here for the possible benefit of others. Thanks for your consideration.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/FirstVertex/patch-2