Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !18043

v4 docs Popovers - confusion with doc class names

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/tshinnic/v4_docs_comp_popovers_typos_1 into v4-dev Oct 24, 2015
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: tshinnic

Extending/elaborating of v3 docs for Popovers introduced confused names for doc example classes. Though v3 docs had similar confusion also.

/docs/assets/scss/_component-examples.scss defines class name bd-example-popover. In file components/popover.md could be found used class names bd-example-popover, bd-example-popover, and bd-popover.

bd-popover was shown in page example code which is bad. Trying out either .popover or .bd-example-popover did not produce useful results, so this change simply deletes these references.

bd-example-popovers was 'corrected' to bd-example-popover in the example "Live demo / Four directions". This added a background which however looks out of place for that example, whereas the existing use in structured example "Static demo" looks nice. Should the class have been deleted instead in "Four directions"?

Also one spelling typo corrected.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/tshinnic/v4_docs_comp_popovers_typos_1