Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !18163

Fix behavior of scrollspy with nested navigation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Drew DeVault requested to merge github/fork/linode/fix-scrollspy into v4-dev Nov 04, 2015
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 2

Consider a nav like this with scrollspy enabled:

<ul class="nav">

    ...

    <li class="nav-item">
        <a class="nav-link" href="#link-2">Link 2</a>
        <ul class="nav">
            <li class="nav-item">
                <a href="#link-2-a" class="nav-link">Link 2-A</a>
            </li>
            <li class="nav-item">
                <a href="#link-2-b" class="nav-link">Link 2-B</a>
            </li>
        </ul>
    </li>

    ...

</ul>

When scrolling without this patch applied and any of these links come into view, they will all receive .active. With this patch applied, the active link and links above it in the tree will receive .active. This matches the behavior of Bootstrap 3.

Before:

After:

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/linode/fix-scrollspy