Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !18234

Replace bootstrap.css png with svg, shorten svg base64 url()s

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/tshinnic/v4_docs_18065_svg_vs_png_2 into v4-dev Nov 13, 2015
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 3

Created by: tshinnic

The desire in issue #18065 (closed) was to replace the single existing embedded .png image with an equivalent SVG image, to go along with the other six existing embedded SVG images. An SVG image was duly produced.

Discussion regarding reducing the size of that url() embedded image ensued, with a suggestion to try url-encoding. In investigating that it was realized that much of the SVG string was overhead which could be discarded. Experimentation found that url-encoding of SVG text would increase the size of the embedded url() strings. In addition the SVG texts were put through an svgo optimizer to drop some more chars.

The single .png image is replaced with a new SVG image, optimized and base64 encoded.

The previously existing 6 SVG images were examined, minimized (unneeded overhead metatext taken out), optimized, and base64 encoded.

All this combined reduces dist/css/bootstrap.css by 2448 bytes, and dist/css/bootstrap.min.css by 2456 bytes.

Additionally, some left-over commented-out code is deleted from scss/_forms.scss. I believe this was commented out in the process of turning the form icons into SASS variables?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/tshinnic/v4_docs_18065_svg_vs_png_2