Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !18272

Ensure transition effect displays on modals with remote content

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/joshreed/master into master Nov 16, 2015
  • Overview 0
  • Commits 9
  • Pipelines 0
  • Changes 18

Created by: joshreed

Currently, remote content, unless loaded really quickly, or already cached in-browser, will not always show the (CSS) transitions, which is a nuisance.

This change makes it so that the "in" class is not added to the modal until loaded even is triggered (if applicable). This seems to work well, though if there are suggestions on a better/preferred alternative implementation, I'm certainly flexible.

Additionally, I did not add any Unit tests, because I didn't see any examples of how you would be handling remote/ajax requests in your tests? This change will only be applicable in situations where the "remote" option is set. I am assuming the best way would be to "mock" the request; if you have any suggestions, I would be happy to add test cases. All existing tests still passed when I ran the suite.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/joshreed/master