Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !18600

Changed .container max-width for large from 940px to 948px

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/arechsteiner/v4-dev into v4-dev Dec 18, 2015
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 3

Created by: arechsteiner

As discussed here:

https://github.com/twbs/bootstrap/issues/13120 and https://github.com/twbs/bootstrap/issues/18510

The two options that make sense are either 948px or 936px. Bootstrap 3 uses 940px. I think it's better to err on the side of having a few pixels more instead of less.

Then all containers will be divisible by 12 by default, which does away with uneven column widths.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/arechsteiner/v4-dev