Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !18807

v4: Figuring out split dropdown buttons

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge v4-split-buttons into v4-dev Jan 08, 2016
  • Overview 0
  • Commits 8
  • Pipelines 0
  • Changes 6

Fixes #18790 (closed) and changes up #17135 (closed).

This is kinda rough and I'm not super stoked on it, but it's the best idea I've had thus far I think. Here's what's going on (to address the split dropdown button spacing with regards to the caret).

  • Added a new functions file to house our strip-unit() function. (In the future this could house a rem-calc function if we wanted one. Note that functions need to be before the variables so that we can use them within the variables file).
  • Adds new classes and variables to address the horizontal spacing within split dropdown toggle buttons. This is kinda shit, but it's explicit and is a single class to add. That's better, at least, than using parents and weirdly rules that are specific to markup.
  • Update the examples to include these new classes, as well as some sizing examples for the split dropdown buttons since we were lacking those anyway.

Still noodling, and open to more ideas if folks have them.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: v4-split-buttons