Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !18888

Allow optional breakpoint arguments to be passed on to nested media query mixins

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/CrispyBacon12/nested-mixins-pass-breakpoints into v4-dev Jan 14, 2016
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: CrispyBacon12

Hello

In cases where a mixin internally uses one of the new media query mixins, the outer mixin should pass the local $breakpoints variable onwards to the nested mixin, otherwise it's defaulting back to the global $grid-breakpoints.

@mixin make-grid-columns optionally accepts a $breakpoints argument already, but attempting to use this doesn't result in anything sensible. Internally it defers to media-breakpoint-up, relying on the default $grid-breakpoints and ignoring what you've passed in.

This is inconsistent with how @mixin media-breakpoint-only and @mixin media-breakpoint-between behave, where the optional $breakpoints argument is passed on internally.

The change to @mixin make-container-max-widths is also included, so that all cases where the media query mixins are nested are consistent.

Doesn't change how anything compiles by default, just gives the option consistently for those using the sass mixins in their own code.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/CrispyBacon12/nested-mixins-pass-breakpoints