Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !19568

include jquery + tether deps for npm package. include gulp. Add .babe…

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/danieldram/v4/include-jquery-tether-deps into v4-dev Mar 18, 2016
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 75

Created by: danieldram

Hi there, This is my first pull request, I tried my best to follow your guidelines so please let me know if I should redo anything or fix anything up.

Our team here is attempting to use Bootstrap 4 with an Angular 2 build. We are also using ES6 module loading syntax and as a result, when we "import 'bootstrap'" it is missing the jQuery and Tether deps. Because there is no global scope we can attach these deps to, we ended up editing your source to require jquery and tether where required. We're using this unofficial version with hopes that in the future release of Bootstrap 4, the npm package will provide those deps instead so we can alway ensure we have the latest stable release.

I included a test example in the /public folder and included an app.js that gets compiled by a gulp build. I added these as I wasn't sure how else to to include a relevant test case for the need for the deps to be apart of v4. I can resubmit a new pull request without these codes if you are okay with what I've submitted so far.

Please let me know if you require anything else or any changes from me in order to make this a successful pull request.

Thanks! Daniel

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/danieldram/v4/include-jquery-tether-deps