Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !19708

Remove tab-focus mixin and add surgical `outline: none` where appropriate

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Patrick H. Lauke requested to merge github/fork/patrickhlauke/v4-focus-outline-simplification into v4-dev Apr 11, 2016
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 7

Explicitly setting a particular outline (e.g. the default outline: thin dotted) overrides heuristics in some modern browsers (such as Firefox) that automagically suppress outline as a result of mouse/tap interaction (while retaining it for keyboard interaction).

This removes the generic tab-focus mixin (mostly leaving outline handling up to the browser and its own heuristics), but also adds explicit outline: none in cases where it's deemed "safe", i.e. where sufficiently clear focus indication is provided (.btn elements, pagination links)

Fixes https://github.com/twbs/bootstrap/issues/18650 / https://github.com/twbs/bootstrap/issues/17006 and the Firefox focus part of https://github.com/twbs/bootstrap/issues/19398

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/patrickhlauke/v4-focus-outline-simplification