Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !19772

Fixed error of Tether getting destroy call second time (Tether 1.3.1)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/vlki/hide-tooltip-twice-tether-error into v4-dev Apr 20, 2016
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 5

Created by: vlki

When using latest Tether 1.3.1, which should be valid based on the ^1.1.1 dependency, calling "hide" two times in a row on tooltip after "show" ends up with tether#destroy() being called second time and error in Tether. Expecting that destroy should be called just once, I updated the code to be the case.

Test included. Minified Tether 1.3.1 added to test vendors. Without the fix the test fail in Chrome 50.0.2661.75, but not in PhantomJS 2.1.1.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/vlki/hide-tooltip-twice-tether-error