Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !19874

Make named anchor/placeholder link style reset more specific

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Patrick H. Lauke requested to merge github/fork/patrickhlauke/v4-links-not-anchors-focusable into v4-dev May 10, 2016
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

This avoids applying the reset to named anchors/placeholder links (links without an href) that have explicitly been made keyboard-focusable (using tabindex). This is not fool-proof - it's not easy/straightforward to check for the actual tabindex value itself, to ensure it's positive, not will this apply if a link has been "blessed" with tabindex via JS. However, this should catch most common uses (and gives a reasonably valid way around the issue for developers who, for whatever reason, DO want to use links without href - as side effect, it forces best practice of at least ensuring these links can also be focused with the keyboard)

(Partially) addresses concerns raised in https://github.com/twbs/bootstrap/pull/19411#issuecomment-218106243

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/patrickhlauke/v4-links-not-anchors-focusable