Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !19906

Tests: Switch from .then to .done to get synchronous operation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/dmethvin/sync-scroll-test into v4-dev May 15, 2016
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: dmethvin

This is the only failure I found in the test suite with jQuery 3.0 and it's easily fixed. 🍕

jQuery 3.0 uses Promise/A+ compliant .then method which is always async. The older .done and .fail methods are still sync. Ref: https://jquery.com/upgrade-guide/3.0/

It's not clear why these two tests use Deferred at all since they appear to be completely synchronous. The giveaway is that there is no QUnit assert.async() call in the test, which you would need if there was any async component.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/dmethvin/sync-scroll-test