Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !1991
An error occurred while fetching the assigned milestone of the selected merge_request.

Fix to make toggling work properly for radio/checkbox buttons that have icons

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/emerencia/master into master 13 years ago
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: emerencia

Right now, clicking a radio/checkbox button* that has an icon only changes its state when the text of the button or the edge of the button around the icon is clicked. When the icon of the button is clicked, the state of the button is not toggled.

This fix makes toggling buttons work by making sure the element to be toggled is actually a "button" or an "a" element and not the "i" tag that holds the image inside of it.

*) This applies to the radio/checkbox buttons that are part of a .btn-group. Not the input elements.

Compare
  • master (base)

and
  • latest version
    c185709b
    1 commit, 2 years ago

1 file
+ 1
- 1

    Preferences

    File browser
    Compare changes
js/bootstrap-button.js
+ 1
- 1
  • View file @ c185709b


@@ -25,7 +25,7 @@
* ============================== */
var Button = function ( element, options ) {
this.$element = $(element)
this.$element = $(element).closest('button, a')
this.options = $.extend({}, $.fn.button.defaults, options)
}
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/emerencia/master

Menu

Explore Projects Groups Snippets