Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !19953

Dropdown perf - on keyboard nav, search for active item in the current dropdown rather than the whole document

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/pvdlg/dropdown-perf into v4-dev May 22, 2016
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: pvdlg

Currently when navigating a dropdown with the keyboard, in order to determine the current index, this selector is used to find the active elements on the whole document. All the dropdown-items on the page are retrieved and looped on with a call to item.offsetWidth and item.offsetHeight to determine if they are currently visible.

With this PR the active items are searched only under the parent dropdown. In addition it avoid the necessity to call item.offsetWidth and item.offsetHeight.

On a side note, the keyboard navigation currently doesn't work in v4 as there is a discrepancy between the html markup (from the documentation) and the javascript. See #19864 for the fix.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/pvdlg/dropdown-perf