Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !20175

Add Wall of Browser Bugs entries for <dialog>

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge dialog-wall into v4-dev Jun 25, 2016
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 3

Created by: cvrebert

I propose adding these on the grounds that <dialog> would make it much easier and less hacky to implement modals. In particular, accomplishing the "disablement" of the underlying page, so that the modal is actually modal, is currently pretty painful.

Refs:

  • https://bugzil.la/840640
  • https://webkit.org/b/84635
  • http://caniuse.com/#feat=dialog
  • https://html.spec.whatwg.org/multipage/forms.html#the-dialog-element

CC: @twbs/team for review

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: dialog-wall