Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !20209

fix too many siblings activation in scrollspy

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/mr-july/v4-dev into v4-dev Jun 29, 2016
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 11

Created by: mr-july

if the scrollspy applied to hierarchical navigation, then too many nav-links are activated. Example markup:

<ul id="toc" class="bs-sidenav nav">
  <li>
    <a href="#v1" class="nav-link">Volume 1</a>
    <ul class="nav">
      <li>
        <a href="#ch-1-1" class="nav-link">Chapter 1.1</a>
      </li>
      <li>
        <a href="#ch-1-2" class="nav-link">Chapter 1.2</a>
      </li>
      <li>
        <a href="#ch-1-3" class="nav-link">Chapter 1.3</a>
      </li>
    </ul>
  </li>
  <li>
    <a href="#v2" class="nav-link">Volume 2</a>
    <ul class="nav">
      <li>
        <a href="#ch-2-1" class="nav-link">Chapter 2.1</a>
      </li>
      <li>
        <a href="#ch-2-2" class="nav-link">Chapter 2.2</a>
      </li>
    </ul>
  </li>
</ul>

on activation of "Chapter 1.2" all siblings ("Chapter 1.1" and "Chapter 1.3") are also activated, because the selector

$('.nav-link[href="#ch-1-2"]').parents('li').find('.nav-links')

matches all ".nav-link"s under "#v1", so the correct selector should be

$('.nav-link[href="#ch-1-2"]').parents('li').find('> .nav-links')
                                                   ^
                                      only direct children of li
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/mr-july/v4-dev