Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !20278

button.js: Set disabled property in addition to disabled attribute

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge jq3-attr-prop into master Jul 12, 2016
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: cvrebert

So as to preserve the existing behavior when running under jQuery 3.

This code ought to have used .prop instead of .attr in the first place, but we can't get rid of the attr manipulation now, due to backward compatibility constraints.

This addresses the only warning that the jQuery Migrate Plugin emitted.

Refs https://github.com/jquery/jquery-migrate/blob/3.0.0/warnings.md#jqmigrate-jqueryfnremoveattr-no-longer-sets-boolean-properties Refs #16834 (closed).

No v4 port is necessary here, since the relevant feature has already been excised from v4's buttons plugin.

CC: @XhmikosR @hnrch02 for review

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: jq3-attr-prop