Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !20463
An error occurred while fetching the assigned milestone of the selected merge_request.

update click state when hiding so can be shown again by trigger

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/maxbeatty/v4-dev-16732 into v4-dev 8 years ago
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: maxbeatty

fixes #16732 (closed) by applying @markbao's suggestion when the tooltip is hidden. addresses issue demonstrated here https://jsbin.com/bapohu/edit?html,js,output. I couldn't reproduce the other 2 scenarios with v4 outlined in #16732 (closed)

Compare
  • v4-dev (base)

and
  • latest version
    c94e45ff
    1 commit, 2 years ago

2 files
+ 17
- 0

    Preferences

    File browser
    Compare changes
j‎s‎
s‎rc‎
toolt‎ip.js‎ +1 -0
tests‎/unit‎
toolt‎ip.js‎ +16 -0
js/src/tooltip.js
+ 1
- 0
  • View file @ c94e45ff


@@ -340,6 +340,7 @@ const Tooltip = (($) => {
}
$(tip).removeClass(ClassName.IN)
this._activeTrigger.click = false
if (Util.supportsTransitionEnd() &&
($(this.tip).hasClass(ClassName.FADE))) {
js/tests/unit/tooltip.js
+ 16
- 0
  • View file @ c94e45ff


@@ -805,4 +805,20 @@ $(function () {
})
})
QUnit.test('should show on first trigger after hide', function (assert) {
assert.expect(3)
var $el = $('<a href="#" rel="tooltip" title="Test tooltip"/>')
.appendTo('#qunit-fixture')
.bootstrapTooltip({ trigger: 'click' })
$el.trigger('click')
assert.ok($('.tooltip').is('.fade.in'), 'tooltip is faded in')
$el.bootstrapTooltip('hide')
assert.ok($('.tooltip').not('.fade.in'), 'tooltip was faded out')
$el.trigger('click')
assert.ok($('.tooltip').is('.fade.in'), 'tooltip is faded in again')
})
})
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/maxbeatty/v4-dev-16732

Menu

Explore Projects Groups Snippets