Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !20596

Use :*-of-type instead of :*-child so that <template>s don't break selectors

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/JonathanWolfe/patch-1 into v4-dev 8 years ago
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: JonathanWolfe

Example of markup this fixes:

<ul class="list-group style-scope list-of-items">

    <li class="list-group-item  style-scope list-of-items" id="25016000000350">
        AAA
    </li>

    <li class="list-group-item  style-scope list-of-items" id="25016000000001">
        Admin
    </li>

    <li class="list-group-item  style-scope list-of-items" id="25016000002594">
        asasd
    </li>

    <template is="dom-repeat" as="row" class="style-scope list-of-items">
        ...
    </template>

</ul>
Compare
  • v4-dev (base)

and
  • latest version
    e9f129cd
    1 commit, 2 years ago

1 file
+ 2
- 2

    Preferences

    File browser
    Compare changes
scss/_list-group.scss
+ 2
- 2
  • View file @ e9f129cd


@@ -22,11 +22,11 @@
background-color: $list-group-bg;
border: $list-group-border-width solid $list-group-border-color;
&:first-child {
&:first-of-type {
@include border-top-radius($list-group-border-radius);
}
&:last-child {
&:last-of-type {
margin-bottom: 0;
@include border-bottom-radius($list-group-border-radius);
}
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
2
css v4
2
css v4
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: twbs/bootstrap!20596
Source branch: github/fork/JonathanWolfe/patch-1

Menu

Explore Projects Groups Snippets