Skip to content
GitLab

Rename `.navbar-toggleable-xs` to `.navbar-toggleable` + more cleanup

Merged Administrator requested to merge github/fork/Starsam80/small-cleanups into v4-dev

Created by: Starsam80

The first commit is purely just whitespace fixes and can be dropped if needed:

  • Align all the CSS properties
  • Remove outdated comment

The second commit does several things:

  • Remove -xs from .navbar-toggleable-xs: While my solution works, it isn't the prettiest. From my experimentation I couldn't find a better way without copying and pasting the whole thing.
  • Remove some duplicate code
  • Move the .navbar-toggleable chunk down to the bottom of the file, so it can override some CSS properties like margin-left without needing !important

The third commit is pretty simple:

  • Rename .navbar-toggleable-xs to .navbar-toggleable
  • Rename .float-xs-(left|right) to .float-(left|right): This fixes several bugs in the docs and examples.

This PR ended up a lot bigger than I would have wanted, but I find it's really hard to separate commits so I can't undo some of the changes I did. Oh well.