Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !21238

Remove lots of duplication + minor cleanup

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/Starsam80/more-cleanup into v4-dev Nov 28, 2016
  • Overview 0
  • Commits 5
  • Pipelines 0
  • Changes 13

Created by: Starsam80

The first commit just removed a comment. I found it funny, actually, because this comment was just commented out code that was exactly the same 2 lines below it.

The second commit just uses the transition mixin everywhere, so the variable $enable-transitions actually affects these.

The third commit introduces a new function, breakpoint-infix. All this function does is to help with removing duplication while keeping it really clean. The fourth commit uses this function, but I've separated it because I knew it would be bigger than the rest. The word "infix" was a result of a quick google search to find out what the term was called when you put a part of something into something else. It can be named to something else, if needed.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Starsam80/more-cleanup