Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !21357

Fixes #16516

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/shehi/patch-1 into v3-dev Dec 16, 2016
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: shehi

This change, just make sure the dropdown-backdrop which was introduced during "touchstart" gets its event handler for "touchend" event, rather than "click" one (which is broken due to delegation bug anyway). When the event is bound on "click", once all dropdowns are closed, it triggers the original initiator again and dropdown gets reopened. With my solution, backdrop is removed successfully and dropdowns close fine.

I realize you guys stopped supporting TWBS 3: please consider accepting this fix in, as I have a project with uses v3 and has unpredictable situation with touch-events. Dropdowns just remain open.

https://github.com/silviomoreto/bootstrap-select/issues/1558

Apparently, the related line in the code was put into if conditional with commit f37b351288883cca4ea435827b10fe6d8475dc6e, but while doing so, whereas the condition contains ontouchstart rule, event itself wasn't updated to some touch-event, it remained as click.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/shehi/patch-1