Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !21459

v4: Miscellaneous states, flexbox, and docs cleanup

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge cleanup-states into v4-dev Dec 28, 2016
  • Overview 0
  • Commits 24
  • Pipelines 0
  • Changes 9

This started out as a general cleanup of our pseudo-classes (to simplify our CSS output), but quickly turned into a smorgasbord of commits. At a high level, this affects navs, navbars, pagination, and list groups, but here's a small rundown of the highlights:

  • Removes plain-hover-focus mixins from navs, navbar navs, pagination, and list groups. As noted in #21439, these things often don't need to be reset for the active/disabled states. This really helps to reduce the compiled CSS selectors.

  • Overhauls the list group a bit to provide better docs, improve Sass variable indentation, cleans up some styles for lighter output.

  • Updates pagination to use flexbox instead of floats and what not. Fixes #20029 (closed) in the process.

  • Revamps pagination docs to include simpler examples, incorporate accessibility notes into the core of the docs instead of as callouts, and provide examples of using flex alignment.

  • Fixes some instances of .open which was recently changed to .show for toggling dropdowns.

My biggest question in this is, do still need these hover mixins for this stuff? @cvrebertc, hoping we can perhaps delete the plain-hover-focus one since that should be shied away from anyway.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: cleanup-states