Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !21462

v4: Simplify navbar further

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge navbar-tweaks into v4-dev Dec 29, 2016
  • Overview 0
  • Commits 18
  • Pipelines 0
  • Changes 13

This PR aims to do a bit more simplification and improvements to the navbar. It addresses the list of todos from #21460 (closed) as a follow-up to redoing the navs with flexbox.

  • Makes the .navbar use flex and flex-direction: column to start for fewer overrides and easier mobile-first styling.
  • Reorganizes the entire file for a more logical order, plus adds a contents list at the top.
  • Removes the need to use .nav on our .navbar-nav.
  • Removes the flex-grow: 10 that was rather random from .navbar-nav and uses .mr-auto for easy spacing of flex items. (This was recently added to our flex utils docs.)
  • Clarifies some class names and directions in the docs.
  • Updates all the examples.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: navbar-tweaks