Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !21535

remove dropdown.js reliance on roles and fix keyboard navigation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/pvdlg/dropdown-keyboard into v4-dev Jan 04, 2017
  • Overview 0
  • Commits 24
  • Pipelines 0
  • Changes 2

Created by: pvdlg

Per migration documentation in https://github.com/twbs/bootstrap/commit/4d8d8bdab4b0e2931fcf92ce30d772b05a989434:

  • Rebuilt dropdown styles and markup to provide easy, built-in support for <a> and <button> based dropdown items.
  • Dropdown items now require .dropdown-item.

In addition fix the the space key behavior on firefox for <button> elements: #21159 (closed). Thanks to @RyanThomasMusser for the analysis here. Fixes #21159 (closed).

This PR:

  • Remove the dependency to role="menu" or role="listbox" and rely on the class dropdown-menu instead
  • Remove the dependency to the a element for the dropdown-item and rely on the class dropdown-item instead
  • Remove the necessity to wrap dropdown-item in li elements

With this modification the javascript now matches the markup in the documentation. The keyboard navigation works again now in dropdowns.

Also fixes #21941 (closed) (see comment)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/pvdlg/dropdown-keyboard