Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !21804

Enable EmptyLineBetweenBlocks linter

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/tagliala/enforce-empty-line-between-blocks into v4-dev Jan 21, 2017
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 19

Created by: tagliala

Hi,

I know this is a quite invasive PR and is highly opinionated.

I've noticed some inconsistent styling in the sources.

The use of empty line between blocks was quite inconsistent, this linter will increase the uniformity of the code.

Examples:

  • badge has empty lines between colored variants https://github.com/twbs/bootstrap/blob/v4-dev/scss/_badge.scss#L58 while alert hasn't https://github.com/twbs/bootstrap/blob/v4-dev/scss/_alert.scss#L47
  • card has both empty lines and not empty lines between *-child selectors https://github.com/twbs/bootstrap/blob/v4-dev/scss/_card.scss#L50 https://github.com/twbs/bootstrap/blob/v4-dev/scss/_card.scss#L236
  • popover has both empty lines and not empty lines between ::before and ::after selectors https://github.com/twbs/bootstrap/blob/v4-dev/scss/_popover.scss#L39 https://github.com/twbs/bootstrap/blob/v4-dev/scss/_popover.scss#L168
  • dropdown has empty lines between -left and -right variants https://github.com/twbs/bootstrap/blob/v4-dev/scss/_dropdown.scss#L124 while navbar hasn't https://github.com/twbs/bootstrap/blob/v4-dev/scss/_navbar.scss#L112
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/tagliala/enforce-empty-line-between-blocks