Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !21812

Remove `cursor: pointer;`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge cursor-pointer into v4-dev Jan 22, 2017
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 6

Turns out using cursor: pointer on actions (e.g., buttons) is incorrect. I removed the cursor: pointer from our buttons in Alpha 6 knowing this, but I left the rest of the properties throughout the codebase for another time. This PR aims to finish that work, removing nearly all the remaining cursor: pointer properties from our CSS.

I still need to figure out the role="button" one for iOS click-ability though.

This would also fix #21781 (closed).


References

From the W3C spec:

pointer The cursor is a pointer that indicates a link.

From Microsoft's design guidelines:

To avoid confusion, it is imperative not to use the hand pointer for other purposes. For example, command buttons already have a strong affordance, so they don't need a hand pointer. The hand pointer must mean "this target is a link" and nothing else.

Regarding the cursor pointer from Apple's HIG:

The content is a URL link.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: cursor-pointer