Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !21972

Form states: set form-control state based on form-group and handle sm and lg size

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/pvdlg/redundant-form-control-state into v4-dev Feb 11, 2017
  • Overview 0
  • Commits 7
  • Pipelines 0
  • Changes 3

Created by: pvdlg

Per documentation:

To use, add .has-warning, .has-danger, or .has-success to the parent element. Any .col-form-label, .form-control, or custom form element will receive the validation styles.

Contrary to what's mentioned in the documentation the classes form-control-success, form-control-warning and form-control-danger are currently required on the form-control.

This PR conforms the code with the documentation and apply the state styles on the form-control based on the state class set on the parent form-group. The behavior of form-control is now similar to form-control-label (takes it's state styles from form-group).

In addition this PR set the position of the state icon based on the form-control size. So if form-control-sm is used with has-success the icon is now sized and positioned properly.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/pvdlg/redundant-form-control-state