Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !22279

Changed Display Utilities classnames

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/simPod/v4-dev into v4-dev Mar 26, 2017
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 10

Created by: simPod

I personally think names should be as much descriptive as possible and that applies for classes as well. I don't fancy naming display class names as .d* so I changed it to .display*.

.d* reminded me my old ways of programming like naming variable containing User object as $u instead of $user or even worse UserModel as $um instead of $userModel The problem with this usually becomes when there's another object with same first letters. eg. UserManager and UserModel. Someone resolves it with $um and $um2 which is not the best way to solve it :)

So IMO class name should say what it does. .display-sm-none says it very well I think. For .d-sm-none I would have to search the docs if I'm user not familiar with Boostrap.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/simPod/v4-dev