Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !22298

Add border width to input height variables

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/jacobmllr95/fix-up-input-height-vars into v4-dev Mar 28, 2017
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 10

Created by: jacobmllr95

This commit adds the border width (top + bottom) to the input height variables by default. This makes IMHO much more sense because every element is set to box-sizing: border-box, so the border height should count to the total element height.

This commit introduces some handy helper functions to convert rem units to px and vice versa. This is required to calculate the total input height because the border width is defined in px and the other height related variables (padding, font-size etc.) are defined in rem.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/jacobmllr95/fix-up-input-height-vars