Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !22301

fix tooltips margins

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/IdanCo/bugfix/22300-tooltips-margins into v4-dev Mar 29, 2017
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: IdanCo

Summary:

As described in #21146 (closed) and #22300 (closed), and shown here, left and top tooltips exhibit inconsistencies in regards to margins.

before

Top and left tooltips sometimes ignore margins

After

All tooltips now use padding instead of margin

Technical

As shown here, top and left tooltips switches between absolute and fixed positions. No doubt this is what causes the inconsistencies, but I admit the logic behind this switch, and the reason it differs from bottom or right tooltips remains an enigma to me. It happens here, but since it's deep inside tether's logic, I tried looking for a workaround in bootstrap's code. Since the margins seems to be what causes the issue, i've successfully replaced them with paddings, while preserving the spacing by adding it to the arrow position.

Example of fix available here - http://jsbin.com/noyitof/edit?html,css,js,output

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/IdanCo/bugfix/22300-tooltips-margins