Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !22392

Carousel fixes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge carousel into v4-dev Apr 08, 2017
  • Overview 0
  • Commits 5
  • Pipelines 0
  • Changes 5

This PR fixes a few carousel issues.

  • Ensures carousel works in IE10 and IE11 by removing the transform3d detection mixin entirely as all our supported browsers support it. There was no fallback being provided, so IE10/11 were left in the dark as we were keying off -webkit detection. Fixes #22198 (closed).

  • Fixes the image aspect ratio issues. Also moved from .img-fluid to .w-100 in our examples. Pulls in @vanduynslagerp's fix from #21799. Fixes #21658 (closed), fixes #21966 (closed), closes #21799.

  • Changes the timing function from ease-in-out to ease to fix the "bouncing" into place when carousel items move. This kinda sucks, but there's no other CSS change I can see us making to fix this issue. Fixes #21685 (closed), fixes #21751 (closed), fixes #22291 (closed).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: carousel