Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !22395

Form updates: Bug fixes, docs update, and validation overhaul

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge form-tweaks into v4-dev Apr 09, 2017
  • Overview 0
  • Commits 49
  • Pipelines 0
  • Changes 9
  • Changes horizontal input and button padding from 1rem to .75rem.
  • Closes #21970 by using the $btn-focus-box-shadow variable on form controls.
  • Fixes #21922 (closed) by nuking border-radius if global radius is disabled.
  • 7efe4dde Adds same focus shadow effect to the form validation mixin.
  • Revamp input and select height calculations. Previously, $input-height and it's sm/lg variants didn't account for top and bottom border-width. This has been redone to utilize three total variables and one calc() function because of mixed units. Closes #22298, closes #22484 which brought the issue to light, and fixes #22105 (closed).
  • Renames $custom-select-sm-* variables to put the -sm at the end, matching our other variables.

Additional commits addressed the following:

  • Fixes #21581 (closed) with additional grid options
  • Closes #22538 by cherry-picking the relevant bits into the new forms docs
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: form-tweaks